Repository navigation
Conversation
…e tasks Spin does not run after-response tasks. Every converted Spin request now carries a scheduler that rejects registration with 501 Not Implemented and the message exported as edgezero_adapter_spin::AFTER_RESPONSE_UNSUPPORTED, instead of core's generic "not supported by this adapter" message. The task is dropped without being polled. The handle is installed in into_core_request_head, which every native Spin entry point uses (run_app, run_app_with_platform, dispatch_app, AppExt::dispatch, dispatch, dispatch_with_kv_label, into_core_request). The capability matrix already reports Spin Unsupported, so required = ["after-response-tasks"] still refuses Spin. Tests: host unit test for the scheduler; wasm32 contract test dispatching a real SpinRequest. Docs: capabilities, Spin guide, changelog, core after_response docs, design and plan.
Installing a rejecting Spin scheduler changes a zero budget from 501 to 500: core now finds a handle and rejects the budget before the scheduler, as it already does on Axum and Fastly. The guides, changelog and spec claimed every Spin registration returns 501 and that the zero budget case was unchanged. Correct them and pin the 500 with a Spin unit test. Also note that core pre-dispatch hooks can replace or remove the handle (removal falls back to core's 501), that PR #512 overlaps on the CHANGELOG line as well as the capabilities bullet, and point the #509 design at the follow-up.
Move the ClientInfo fixture types before the module's functions so Cloudflare wasm clippy passes without test-utils, and stop the Debug redaction test from printing captured values in its assertion message (CodeQL rust/cleartext-logging).
Restore the pre-ClientInfo order so a generic JA4 header named in the forwarding family is never read, and pin it with a regression case.
Test helpers now pass a NotExposed snapshot, so neither adapter repeats core's optional dispatch branch. Add Manifest::client_info_direct_ingress for the shared manifest lookup, and reuse the ALB admission and trusted-peer checks in Axum.
SpinClientSource replaces the direct_ingress flag and optional Geo selection, so the conflicting pair cannot be stored. Managed contract tests now assert the exact ClientInfo for authenticated Geo, failed lookups, off mode and direct ingress, with IP-selective Geo data.
The handler guide limits the private snapshot to client_info() and geo(). The Axum guide explains that generated apps stay on the development runner unless a bindings file selects production.
#517 (10ed380) tops ChristianPavilonis's line on #439: - #510, the KvStore record contract with DynamoDB and celld providers on Axum (#472, #473); - #454, portable KV-backed geo; - #514, country and region through ctx.geo() on Cloudflare and Spin (#480, #486); - #517, the portable ClientInfo contract with its Fastly, Axum, Cloudflare and Spin mappings (#475, #90, #91, #92, #485). #517 also merged #469 and #502 itself, so its tree contains everything this branch had. The only conflicts were JA4 lines that #517 refactors on top of #469; this merge takes #517's version, and its tree is identical to #517's.
#509 (2620377) adds bounded work after the response on Fastly and Axum, drained on Axum SIGTERM (EZI-1, #476). #512 (cdc232c) runs it on Cloudflare through waitUntil (#478), and #515 (ec347a2) reports Spin's capability error (#483). The line now stacks on #517 and each PR merged the one below it, so this merge is clean.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rc/identityis the integration branch for server-side identity on every adapter (Platform capabilities for server-side identity on every adapter #468). It carries the ready PRs that Trusted Server's Fastly and Axum MVP needs, joined by history-preserving merges, so Trusted Server can pin one revision and CI can test the combined stack.Included
On main
e11ea308. Heads are current at9d02d7b3; earlier heads stay in the history.ea2549fbc5c6b8e0ce94fe06e37e0df2d3188b1a164995311d89fb4ee9459356c02ee54961fd14d78cd7af96ctx.geo(), and Axum geo bound from the manifest (#482)f2cacc67KvStorerecord contract with listing strong within a partition, and DynamoDB and celld providers on Axum (#472, #473)925fe019ec0b912bctx.geo()on Cloudflare and Spin (#480, #486)10ed38032620377acdc232c8waitUntil(#478)ec347a2cMoved since
9d02d7b3None.
#463 closed on 2026-11-13; #422 carries its conditional celld record operations, which this branch already has.
How the record-contract, ClientInfo and after-response lines came in (2026-11-18)
ChristianPavilonis's line on #439 runs
#510 → #454 → #517; #517 also merged #469, #502 and #514 itself. Its tree contains everything this branch had, soef8225d9merged #517. The only conflicts were JA4 lines that #517 refactors on top of #469 (Ja4Selectionin place ofTrustedJa4Header); the merge takes #517's version, and its tree is identical to #517's.prk-Jr's after-response line sat on #406, so it conflicted with the stack above it. The fix is in the PRs: #509 merged #517 (
2620377a), #512 merged #509 (cdc232c8), and #515, which conflicted with #512 in the changelog and the capabilities guide, now stacks on #512 (ec347a2c). This branch took #515's head as the plain merge9d02d7b3, whose tree is identical to #515's. On GitHub the whole line is stack 511, from #499 up to #515; stack 516 was dissolved so #509 could change base.How #502 came in (2026-11-17)
#502 was stacked on #439's earlier head
645703bf, and #439's refreshed head conflicted with it in one place: theManifeststruct's schema validators inedgezero-core'smanifest.rs, where #502 adds the adapter geo placement check and #439 brings #275's Fastly logging check. #502's own merge8cd7af96(Merge PR #439 into PR #502 for outbound compatibility stack) keeps both, after the existing case-unique adapter keys check. This branch then took #502 as a plain merge,b6ada1cc, with no conflicts.How #275's next review repairs came in (2026-11-17)
#275 moved from
b65e7144toea2549fbby adding 16 fix and docs commits (Fastly response handles and progress wakers, retained outbound failures, body checkpoints, harness supervision, CLI target pinning). #422 had added a stock-celld store service (dd1b8907,15bdeef6), which #439 merged incf291a1e. Each stack PR then merged the PR below it, bottom-up, with no conflicts, and this branch took #439's headc02ee549as a plain merge,f84ffbbb.How #275's review repairs came in (2026-11-16)
#275 moved from
e9ffaa8ftob65e7144by adding four commits:4cbabfee: Fastly logging validation and setup failures (Fastly custom runners send no response when the managed logger fails to install #505, Reject Fastly logging endpoint names the logger cannot install when the manifest loads #506).fe32185f: terminal errors and response policies.c7e3ac97: assembly-failure attestation tests.b65e7144: compile-time logging config for hand-written hooks (Compile-timelogging_forfor applications with a hand-writtenHooksimpl #504).Each stack PR merged the PR below it again, bottom-up, in a merge commit titled
Merge PR #<lower> into PR #<N> for outbound compatibility stack. Only #409 conflicted. Its merge resolves the import block of edgezero-core'sapp.rsby keeping both imports: #409'sRouteErrorKindand #275'sRequiredErrorResponseHeaders. This branch then took #439's headc1cec8e7as a plain merge,3d92ee38, with no conflicts.How #275's rewrite came in
#275's head was rewritten at
e9ffaa8f. The stack's conflicts were not resolved here. Instead, each stack PR merged the PR below it, bottom-up, and resolved its own conflicts in its own merge commit, titledMerge PR #<lower> into PR #<N> for outbound compatibility stack. Rungit show --remerge-diffon a PR's merge to see exactly what its resolution changed. This branch then takes #439's head in a single merge.cf8003f1expect, and its byte-bound assertion under #275's record caps03d192fdb3187e1brun_localandrun_ownedstructure, which now owns #275'sAxumOutboundExecutor77fa6772forwarded_content_lengthandingress_buffer;with_transporttakes the executor and the JSON limite1350bb2from_app_with_native_client_factorytakes the executor; dispatch keeps #409'sinto_partsand inserts the executorbd6cb7abf1d85581302697e8with_native_transporttakes the executor; both theexecutorandgeofieldsEdit in this branch's own merge
87174160merged #439's head with two edits where #469 meets #275, andgit show --remerge-diff 87174160shows both. One is still this branch's own:request.rs: #469'singress_ja4_is_not_exposed_even_with_ja4_headerstest gets an executor handleinto_core_request, and the test does not compile without one. #469 targets main, where the function still takes one argument, so the edit cannot live in #469 until it rebases onto #275The other removed
EdgeZeroAxumServicefrom the Axum guide, because #275'scheck_outbound_legacy_api.shrejects the name. That edit now comes from #469 itself (52f4a09f, the suggestion in its review), merged in10166628with no file change. It was the only red check here before.Open points for the owning PRs
request.rsedit aboveWouldBlock(#503)Not included
Next on this branch
Each ticket's PR is merged here once it is ready. Every R1b, R2 and R2b ticket's PR is now included; R3 and R4 wait only on their record stores.
Refs #488. Part of #468. Planned in IABTechLab/trusted-server#1559.
Test plan
b6ada1ccthrough history-preserving merges10166628has the same tree as8717416087174160check_outbound_legacy_api.shandcheck_outbound_docs_contract.mjson8717416010166628(IABTechLab/trusted-server#1506 and IABTechLab/trusted-server#1608)10166628cache-restore-seedfailed once on compiler-cache publication and passed on reruncargo fmt --all -- --check,cargo check --workspace --all-targets --features "fastly cloudflare",cargo clippy --workspace --all-targets --all-features -- -D warnings,cargo test --workspace --all-targets3d92ee38f84ffbbb8cd7af96, locally:cargo fmt --all -- --check,cargo clippy --workspace --all-targets --all-features -- -D warnings,cargo test -p edgezero-core,cargo test -p edgezero-adapter-axum --features geo-cloudfront,cargo check --workspace --all-targets --features "fastly cloudflare spin", Fastly lib clippyb6ada1cc, locally: fmt,check_outbound_legacy_api.sh,check_outbound_docs_contract.mjs, workspace clippy, both Fastly clippy runs, the wasm feature check andcargo test --workspace --all-targets2620377a, #512 atcdc232c8and #515 atec347a2c, each locally: fmt, workspace clippy with all features, both Fastly clippy runs, the wasm feature check, workspace tests, both outbound scripts; plus Fastly contract tests under Viceroy, Cloudflare wasm tests in Node and Spin contract tests under Wasmtimeef8225d9has the same tree as #517's head10ed3803, and9d02d7b3the same tree as #515's headec347a2c10ed3803